Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update protobuf to v22.1 #168

Closed
wants to merge 1 commit into from
Closed

Update protobuf to v22.1 #168

wants to merge 1 commit into from

Conversation

malt3
Copy link

@malt3 malt3 commented Mar 9, 2023 •
edited
Loading

Mirror request.

Resolves #163 since protocolbuffers/protobuf#12063 was merged + released with v22.1:

Modify release artifacts for protoc to statically link system libraries.

@malt3 malt3 requested review from lberki and comius as code owners March 9, 2023 10:13
@malt3 malt3 mentioned this pull request Mar 15, 2023
Closed
3 tasks
comius
comius requested changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@comius comius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a dep in line MODULE.bazel line 8 to protobuf 21.7. Please prepare a PR for bazel-central-registry with new version of protobuf and update the version here as well.

@malt3
Copy link
Author

malt3 commented May 9, 2023

I'm on vacation and will get to it next week.

@malt3 malt3 marked this pull request as draft May 30, 2023 09:52
@malt3
Copy link
Author

malt3 commented May 30, 2023

I'll wait until bazelbuild/bazel-central-registry#532 is merged. It adds support for protobuf 22.2 in bcr and should be trivial to adapt to 22.1 once that is ready.

This was referenced May 30, 2023
Closed
Closed
@comius
Copy link
Collaborator

comius commented Oct 9, 2023

Closed, because it's stale.

@comius comius closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comius comius comius requested changes

@lberki lberki Awaiting requested review from lberki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

protoc is dynamically linked
2 participants
@malt3 @comius