-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pypi): handle multiple versions of the same package when parsing requirements files #2377
fix(pypi): handle multiple versions of the same package when parsing requirements files #2377
Conversation
3e05fbf
to
3002d39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Does this fix the #2337 issue? Looking at the fix here this may be the case, but I am not sure.
3002d39
to
273b162
Compare
Yes that is correct |
I have reworded the commit message a little bit and changed the title since this is more like a fix to an existing feature rather than a new featuer. LGTM in general, could you please add a CHANGELOG.md note as well that this PR fixes an open issue? Something like:
|
273b162
to
23e7f7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, could you please move the changelog entry to the unreleased block? It might have messed up during a merge/rebase.
8653c45
to
06cfc3c
Compare
This change makes it possible to handle local versions of packages,
which is extremely useful with PyTorch. With this change, it is
possible to have different local versions of the same package in the
requirements.txt
file translated to validwhl_library
repositories.Fixes #2337