Added rustfmt_toolchain and refactored toolchain repository rules
#1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
force-pushed
the
rustfmt
branch
3 times, most recently
from
87529ea to
38c0d59
Compare
krasimirgg
approved these changes
Dec 22, 2022
|
@illicitonion any concerns? |
illicitonion
approved these changes
Jan 3, 2023
lucasbergman
added a commit
to lucasbergman/rules_nixpkgs
that referenced
this pull request
Dec 5, 2024
This makes the nixpkgs_rust_configure repo rule add a rustfmt_toolchain alongside rust_toolchain, using the same rustfmt binary as the former. Support for a separate toolchain for rustfmt was added in bazelbuild/rules_rust#1719.
lucasbergman
added a commit
to lucasbergman/rules_nixpkgs
that referenced
this pull request
Dec 10, 2024
This makes the nixpkgs_rust_configure repo rule add a rustfmt_toolchain alongside rust_toolchain, using the same rustfmt binary as the former. Support for a separate toolchain for rustfmt was added in bazelbuild/rules_rust#1719.
lucasbergman
added a commit
to lucasbergman/rules_nixpkgs
that referenced
this pull request
Dec 10, 2024
This makes the nixpkgs_rust_configure repo rule add a rustfmt_toolchain alongside rust_toolchain, using the same rustfmt binary as the former. Support for a separate toolchain for rustfmt was added in bazelbuild/rules_rust#1719.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a
rustfmt_toolchainand refactors repository rules to create this toolchain over addingrustfmtto the standardrust_toolchain. This new toolchain saves time and disk space since in many casesrustfmtis not required for compiling.Additionally,
rust_register_toolchainshas been refactored to deprecateversionandiso_date. Instead, this information can be conveyed throughversionsandrustfmt_versionby passing variables such as the following["1.66.0", "nightly/2022-12-15"].