-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for split_coverage_post_processing #2000
Conversation
44945cf
to
98f2f35
Compare
bazelbuild/bazel#18634 is required as |
Seeing some odd timeouts on some tests: https://buildkite.com/bazel/rules-rust-rustlang/builds/8718#0188ad81-d635-4fc5-be1a-cb4c1222f476 @illicitonion wondering if you have any ideas as to what might be causing this? |
I'm not sure, sorry! Hopefully if you can fetch some logs from the timing out tests there's something useful in there... |
9ca5833
to
e943c30
Compare
I figured out the issue and am now waiting for bazelbuild/bazel#18634 |
e686fbf
to
440ab13
Compare
053015c
to
28ddee1
Compare
ac4df12
to
d222758
Compare
@illicitonion or @krasimirgg friendly ping 😅 |
@UebelAndre I'm looking into this, also reading up and going over the dependencies. So is this just a "nice simplification" towards experimental_split_coverage_postprocessing support? |
@krasimirgg It turned out it was necessary. If you look at https://github.com/bazelbuild/bazel/blob/6.3.0/src/main/starlark/builtins_bzl/common/cc/cc_binary.bzl#L204 the fix is using internal functionality from cc_common to add additional files to the coverage action. My assumption was that whatever |
Thanks for clarifying! Looks good! |
This change introduces
experimental_use_coverage_metadata_files
(#2082) which is required to support --experimental_split_coverage_postprocessing'Changes:
--@rules_rust//rust/settings:experimental_use_coverage_metadata_files
to toggle the changes necessary for supporting--experimental_split_coverage_postprocessing
.--experimental_split_coverage_postprocessing
.