Apply extra_rustc_flags list to all toolchains #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a starlark newbie, feedback welcome! |
nmattia
force-pushed
the
nm-extra-rustc-flags
branch
from
6c16544
to
ab39931
Compare
This fixes `rust_register_toolchains` to correctly call `rust_toolchain_repository` with a list of `extra_rustc_flags`. Previously, the `extra_rustc_flags` argument of `rust_register_toolchains` was assumed (when set) to be a dict of toolchain triple to list. With this change, a `list` parameter is used for all toolchain triples.
nmattia
force-pushed
the
nm-extra-rustc-flags
branch
from
ab39931
to
e0b382d
Compare
rrbutani
referenced
this pull request
in bazel-contrib/toolchains_llvm
Jul 9, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rules_rust](https://github.com/bazelbuild/rules_rust) | http_archive | minor | `0.46.0` -> `0.47.1` | --- ### Release Notes <details> <summary>bazelbuild/rules_rust (rules_rust)</summary> ### [`v0.47.1`](https://github.com/bazelbuild/rules_rust/releases/tag/0.47.1) [Compare Source](https://github.com/bazelbuild/rules_rust/compare/0.46.0...0.47.1) ### 0.47.1 #### Bzlmod ```python bazel_dep(name = "rules_rust", version = "0.47.1") ``` #### WORKSPACE ```python load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "rules_rust", integrity = "sha256-35cwdTOaqqu4y+aXgIUU2C2PAKMz4+uyJ7/UMIGCmFs=", urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.47.1/rules_rust-v0.47.1.tar.gz"], ) ``` Additional documentation can be found at: https://bazelbuild.github.io/rules_rust/#setup #### What's Changed - Remote vendor doesn't require srcs present by [@​illicitonion](https://github.com/illicitonion) in [https://github.com/bazelbuild/rules_rust/pull/2688](https://github.com/bazelbuild/rules_rust/pull/2688) - Add flag to refer to a `sh_toolchain` for process wrapper bootstrap shebangs by [@​UebelAndre](https://github.com/UebelAndre) in [https://github.com/bazelbuild/rules_rust/pull/2694](https://github.com/bazelbuild/rules_rust/pull/2694) - Added Rust 1.79.0 by [@​UebelAndre](https://github.com/UebelAndre) in [https://github.com/bazelbuild/rules_rust/pull/2695](https://github.com/bazelbuild/rules_rust/pull/2695) - `crate_universe`: Make module extension restarts less expensive. by [@​criemen](https://github.com/criemen) in [https://github.com/bazelbuild/rules_rust/pull/2691](https://github.com/bazelbuild/rules_rust/pull/2691) - Add example of using JNI to call into Rust by [@​illicitonion](https://github.com/illicitonion) in [https://github.com/bazelbuild/rules_rust/pull/2690](https://github.com/bazelbuild/rules_rust/pull/2690) - Apply extra_rustc_flags list to all toolchains by [@​nmattia](https://github.com/nmattia) in [https://github.com/bazelbuild/rules_rust/pull/2693](https://github.com/bazelbuild/rules_rust/pull/2693) - rust-analyzer: Factor aliases into the project by [@​illicitonion](https://github.com/illicitonion) in [https://github.com/bazelbuild/rules_rust/pull/2709](https://github.com/bazelbuild/rules_rust/pull/2709) - crate_universe docs: Split bzlmod from workspace by [@​illicitonion](https://github.com/illicitonion) in [https://github.com/bazelbuild/rules_rust/pull/2700](https://github.com/bazelbuild/rules_rust/pull/2700) - Updated external dependencies docs by [@​UebelAndre](https://github.com/UebelAndre) in [https://github.com/bazelbuild/rules_rust/pull/2711](https://github.com/bazelbuild/rules_rust/pull/2711) - Update wasm-bindgen to 0.2.92 by [@​alexkirsz](https://github.com/alexkirsz) in [https://github.com/bazelbuild/rules_rust/pull/2714](https://github.com/bazelbuild/rules_rust/pull/2714) - upstream wrappers for cargo, rustc, cargo-clippy by [@​kolloch](https://github.com/kolloch) in [https://github.com/bazelbuild/rules_rust/pull/2703](https://github.com/bazelbuild/rules_rust/pull/2703) - Clean up downloads that go through the API instead of the CDN by [@​ograff](https://github.com/ograff) in [https://github.com/bazelbuild/rules_rust/pull/2718](https://github.com/bazelbuild/rules_rust/pull/2718) - Updated rust-analyzer to use repo vs generated files as crate roots by [@​UebelAndre](https://github.com/UebelAndre) in [https://github.com/bazelbuild/rules_rust/pull/2717](https://github.com/bazelbuild/rules_rust/pull/2717) - crate-universe allows workspaces with MODULE.bazel only by [@​matt-duch](https://github.com/matt-duch) in [https://github.com/bazelbuild/rules_rust/pull/2720](https://github.com/bazelbuild/rules_rust/pull/2720) - Release 0.47.0 by [@​UebelAndre](https://github.com/UebelAndre) in [https://github.com/bazelbuild/rules_rust/pull/2725](https://github.com/bazelbuild/rules_rust/pull/2725) - Update bindgen.bzl to use toolchain system include directories as well by [@​hlopko](https://github.com/hlopko) in [https://github.com/bazelbuild/rules_rust/pull/2727](https://github.com/bazelbuild/rules_rust/pull/2727) - Use newer macos runners by [@​ograff](https://github.com/ograff) in [https://github.com/bazelbuild/rules_rust/pull/2732](https://github.com/bazelbuild/rules_rust/pull/2732) #### New Contributors - [@​nmattia](https://github.com/nmattia) made their first contribution in [https://github.com/bazelbuild/rules_rust/pull/2693](https://github.com/bazelbuild/rules_rust/pull/2693) - [@​kolloch](https://github.com/kolloch) made their first contribution in [https://github.com/bazelbuild/rules_rust/pull/2703](https://github.com/bazelbuild/rules_rust/pull/2703) - [@​matt-duch](https://github.com/matt-duch) made their first contribution in [https://github.com/bazelbuild/rules_rust/pull/2720](https://github.com/bazelbuild/rules_rust/pull/2720) **Full Changelog**: bazelbuild/rules_rust@0.46.0...0.47.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/bazel-contrib/toolchains_llvm). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2692
This fixes
rust_register_toolchainsto correctly callrust_toolchain_repositorywith a list ofextra_rustc_flags.Previously, the
extra_rustc_flagsargument ofrust_register_toolchainswas assumed (when set) to be a dict of toolchain triple to list. With this change, alistparameter is used for all toolchain triples.