-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upstream wrappers for cargo, rustc, cargo-clippy #2703
upstream wrappers for cargo, rustc, cargo-clippy #2703
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
4ef91dd
to
7b16019
Compare
@illicitonion also offered to have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just one question around tests :)
bc74ed8
to
c99007b
Compare
@illicitonion as described above, I am now prepending the Also added some tests as requested that test this. |
634edee
to
0a24c36
Compare
...so we can reuse it for more upstream binaries
...and simplify target names of wrappers
0a24c36
to
ff5713c
Compare
@illicitonion I rebased it on #2700 since it had conflicts. (Thanks BTW) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks so much!
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rules_rust](https://github.com/bazelbuild/rules_rust) | http_archive | minor | `0.46.0` -> `0.47.1` | --- ### Release Notes <details> <summary>bazelbuild/rules_rust (rules_rust)</summary> ### [`v0.47.1`](https://github.com/bazelbuild/rules_rust/releases/tag/0.47.1) [Compare Source](https://github.com/bazelbuild/rules_rust/compare/0.46.0...0.47.1) ### 0.47.1 #### Bzlmod ```python bazel_dep(name = "rules_rust", version = "0.47.1") ``` #### WORKSPACE ```python load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "rules_rust", integrity = "sha256-35cwdTOaqqu4y+aXgIUU2C2PAKMz4+uyJ7/UMIGCmFs=", urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.47.1/rules_rust-v0.47.1.tar.gz"], ) ``` Additional documentation can be found at: https://bazelbuild.github.io/rules_rust/#setup #### What's Changed - Remote vendor doesn't require srcs present by [@​illicitonion](https://github.com/illicitonion) in [https://github.com/bazelbuild/rules_rust/pull/2688](https://github.com/bazelbuild/rules_rust/pull/2688) - Add flag to refer to a `sh_toolchain` for process wrapper bootstrap shebangs by [@​UebelAndre](https://github.com/UebelAndre) in [https://github.com/bazelbuild/rules_rust/pull/2694](https://github.com/bazelbuild/rules_rust/pull/2694) - Added Rust 1.79.0 by [@​UebelAndre](https://github.com/UebelAndre) in [https://github.com/bazelbuild/rules_rust/pull/2695](https://github.com/bazelbuild/rules_rust/pull/2695) - `crate_universe`: Make module extension restarts less expensive. by [@​criemen](https://github.com/criemen) in [https://github.com/bazelbuild/rules_rust/pull/2691](https://github.com/bazelbuild/rules_rust/pull/2691) - Add example of using JNI to call into Rust by [@​illicitonion](https://github.com/illicitonion) in [https://github.com/bazelbuild/rules_rust/pull/2690](https://github.com/bazelbuild/rules_rust/pull/2690) - Apply extra_rustc_flags list to all toolchains by [@​nmattia](https://github.com/nmattia) in [https://github.com/bazelbuild/rules_rust/pull/2693](https://github.com/bazelbuild/rules_rust/pull/2693) - rust-analyzer: Factor aliases into the project by [@​illicitonion](https://github.com/illicitonion) in [https://github.com/bazelbuild/rules_rust/pull/2709](https://github.com/bazelbuild/rules_rust/pull/2709) - crate_universe docs: Split bzlmod from workspace by [@​illicitonion](https://github.com/illicitonion) in [https://github.com/bazelbuild/rules_rust/pull/2700](https://github.com/bazelbuild/rules_rust/pull/2700) - Updated external dependencies docs by [@​UebelAndre](https://github.com/UebelAndre) in [https://github.com/bazelbuild/rules_rust/pull/2711](https://github.com/bazelbuild/rules_rust/pull/2711) - Update wasm-bindgen to 0.2.92 by [@​alexkirsz](https://github.com/alexkirsz) in [https://github.com/bazelbuild/rules_rust/pull/2714](https://github.com/bazelbuild/rules_rust/pull/2714) - upstream wrappers for cargo, rustc, cargo-clippy by [@​kolloch](https://github.com/kolloch) in [https://github.com/bazelbuild/rules_rust/pull/2703](https://github.com/bazelbuild/rules_rust/pull/2703) - Clean up downloads that go through the API instead of the CDN by [@​ograff](https://github.com/ograff) in [https://github.com/bazelbuild/rules_rust/pull/2718](https://github.com/bazelbuild/rules_rust/pull/2718) - Updated rust-analyzer to use repo vs generated files as crate roots by [@​UebelAndre](https://github.com/UebelAndre) in [https://github.com/bazelbuild/rules_rust/pull/2717](https://github.com/bazelbuild/rules_rust/pull/2717) - crate-universe allows workspaces with MODULE.bazel only by [@​matt-duch](https://github.com/matt-duch) in [https://github.com/bazelbuild/rules_rust/pull/2720](https://github.com/bazelbuild/rules_rust/pull/2720) - Release 0.47.0 by [@​UebelAndre](https://github.com/UebelAndre) in [https://github.com/bazelbuild/rules_rust/pull/2725](https://github.com/bazelbuild/rules_rust/pull/2725) - Update bindgen.bzl to use toolchain system include directories as well by [@​hlopko](https://github.com/hlopko) in [https://github.com/bazelbuild/rules_rust/pull/2727](https://github.com/bazelbuild/rules_rust/pull/2727) - Use newer macos runners by [@​ograff](https://github.com/ograff) in [https://github.com/bazelbuild/rules_rust/pull/2732](https://github.com/bazelbuild/rules_rust/pull/2732) #### New Contributors - [@​nmattia](https://github.com/nmattia) made their first contribution in [https://github.com/bazelbuild/rules_rust/pull/2693](https://github.com/bazelbuild/rules_rust/pull/2693) - [@​kolloch](https://github.com/kolloch) made their first contribution in [https://github.com/bazelbuild/rules_rust/pull/2703](https://github.com/bazelbuild/rules_rust/pull/2703) - [@​matt-duch](https://github.com/matt-duch) made their first contribution in [https://github.com/bazelbuild/rules_rust/pull/2720](https://github.com/bazelbuild/rules_rust/pull/2720) **Full Changelog**: bazelbuild/rules_rust@0.46.0...0.47.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/bazel-contrib/toolchains_llvm). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore: point to non-deprecated rustfmt See bazelbuild/rules_rust#2703 * chore: upgrade rules_rust * Update Bar.java
...and a bazel_env example.
As discussed in https://bazelbuild.slack.com/archives/CSV56UT0F/p1718207171652029?thread_ts=1718182474.631279&cid=CSV56UT0F