Fix maven_servers parameter passing in scala_repositories #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scala_repositories should use the passed parameter value instead of providing _default_maven_server_urls as a value passed downstream.
liucijus
approved these changes
Dec 14, 2020
|
One of the tests failed, I don't really understand why (on timeout). Can the test be re-triggered? |
|
Thank you! Tests are passing now. |
|
Thanks, @gergelyfabian! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
scala_repositories should use the passed parameter value instead of providing _default_maven_server_urls as a value passed downstream.
Motivation
scala_repositories does not currently work with custom maven_servers attribute as the implementation uses the default anyhow.
This blocks rules_scala if the default maven repositories are unavailable (e.g. in restricted company networks).