Fix error reporting on 2.11 #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SocksDevil
commented
Jan 12, 2021
|
|
||
| static { | ||
| try { | ||
| reporterField = Driver.class.getDeclaredField("reporter"); // NoSuchFieldException |
There was a problem hiding this comment.
This field could be maintained to get access to the ReportableMainClass implementation on our side, but I do think this would be unnecessary added complexity.
|
@andrefmrocha #1176 is merged. Let's proceed with this one? |
SocksDevil
force-pushed
the
2.11-error-reports
branch
from
d9d737a
to
c0c9741
Compare
Should be gtg! Let me know what you think |
liucijus
reviewed
Jan 13, 2021
|
@andrefmrocha can you fix #1177 (comment) from previous PR and we can merge this one |
Was precisely doing it right now 😄 ! |
liucijus
approved these changes
Jan 14, 2021
ittaiz
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1161 . Changed how the reporter is obtained from the
MainClass, since the call togetDeclaredFieldis obtaining the wrong reporter for scala 2.11.Motivation
Fixes problems regarding building for scala 2.11, where the build was exiting without flagging errors, whenever the
DiagnosticsReporterwas used