Stamp scalac jars #1178
Stamp scalac jars #1178
Conversation
| @@ -265,8 +266,18 @@ public static void buildJar(String[] args) throws IOException { | |||
| manifestFile = args[1]; | |||
| idx = 2; | |||
| } | |||
|
|
|||
| String targetLabel = null; | |||
There was a problem hiding this comment.
Probably usage message needs to be updated. Current impl requires flags in specific order ie -m ... -t ... maybe need to be more flexible here?
There was a problem hiding this comment.
I tried to do a minimal change here - it's a copy/paste from bazel: https://github.com/bazelbuild/bazel/blob/master/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/jarhelper/JarCreator.java
I think better solution would be to research and find a way to depend on the original code and extend/override its functionality. But that's probably too big for this PR.
There was a problem hiding this comment.
Added info to usage string
|
|
👍 looks good. Resolve the conflict and merge |
liucijus
force-pushed
the
stamp-scalac-jars
branch
from
0e1e7b0
to
c38e059
Compare
ScalacWorker stamps jars with target label