Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove specs2 binds #1184

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Remove specs2 binds #1184

merged 2 commits into from
Jan 22, 2021

Conversation

liucijus
Copy link
Collaborator

Removes binds from specs2 test rules. Users should use testing toolchain deps to customize specs2 dependencies.

Copy link
Member

@ittaiz ittaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Should we have a docs section about commits with breaking changes and maybe links to the code migration suggestion?

@liucijus
Copy link
Collaborator Author

LGTM.
Should we have a docs section about commits with breaking changes and maybe links to the code migration suggestion?

Maybe then we should move to releases? Otherwise, it's hard to follow what happened when, and which version is following which.

@ittaiz
Copy link
Member

ittaiz commented Jan 22, 2021

We can. I feel releases might be a bit too big of a hammer for this need but I'm open to it.
Also I'm not sure I'd like to do it here and now.
I think we should discuss this in slack and get some feedback. Or maybe just link to a github issue about it.
Concretely do you think we should merge as is without documenting this change?
Also cc @simuons

@liucijus
Copy link
Collaborator Author

We can. I feel releases might be a bit too big of a hammer for this need but I'm open to it.
Also I'm not sure I'd like to do it here and now.
I think we should discuss this in slack and get some feedback. Or maybe just link to a github issue about it.
Concretely do you think we should merge as is without documenting this change?

I think this change is compatible with existing docs, probably it's ok to merge. It should not be hard to migrate to toolchains.

@ittaiz ittaiz merged commit f08de1f into bazelbuild:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants