Linter script #1191
Merged
Linter script #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
liucijus
commented
Jan 27, 2021
liucijus
commented
- adds linting tool with reduced number of warning rules (I've disabled ones which are harder to fix quickly)
- lint starlark files
simuons
reviewed
Jan 27, 2021
lint.sh
Outdated
| @@ -2,4 +2,6 @@ | |||
|
|
|||
| set -eou pipefail | |||
|
|
|||
| ./tools/bazel run //tools:buildifier@fix | |||
| bazel run //tools:buildifier@fix | |||
There was a problem hiding this comment.
Is there really a need for two commands? Why not have one with lint and format?
There was a problem hiding this comment.
moved to a single command
liucijus
force-pushed
the
linter-script
branch
from
d8fb352
to
9addd11
Compare
simuons
approved these changes
Jan 28, 2021
ittaiz
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.