Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move examples build to bk #1192

Merged
merged 5 commits into from
Jan 27, 2021
Merged

Move examples build to bk #1192

merged 5 commits into from
Jan 27, 2021

Conversation

liucijus
Copy link
Collaborator

Move examples testing to BuildKite

@liucijus liucijus requested a review from ittaiz as a code owner January 27, 2021 09:19
@google-cla google-cla bot added the cla: yes label Jan 27, 2021
or-shachar
or-shachar approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@or-shachar or-shachar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(just curiosity question - what's the difference in durations between travis and bk?)

ittaiz
ittaiz approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@ittaiz ittaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you know why the checks are still pending?

@liucijus
Copy link
Collaborator Author

Looks good. Do you know why the checks are still pending?

@ittaiz where do you see pending checks?

@liucijus
Copy link
Collaborator Author

LGTM!
(just curiosity question - what's the difference in durations between travis and bk?)

Roughly BuildKite 1.34 vs Travis 2.30 min

@ittaiz ittaiz merged commit 41005de into bazelbuild:master Jan 27, 2021
@ittaiz
Copy link
Member

ittaiz commented Jan 27, 2021

on my phone it showed the checks as pending

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ittaiz ittaiz ittaiz approved these changes

@or-shachar or-shachar or-shachar approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liucijus @ittaiz @or-shachar