Validate repository Scala version against scala_config #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case there are no overrides, we fail the build if Scala version in scala_config does not match available version in default repositories. Additionally, macros `rules_scala_toolchain_deps_repositories` and `rules_scala_setup` are exported for easier setup of Rules Scala dependencies
liucijus
force-pushed
the
validate-repositories-scala-version
branch
from
a744041
to
fb8f661
Compare
simuons
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add validation to prevent Scala version mismatch between
scala_configand default repositories.In case there are no overrides, we fail the build if Scala version in scala_config does not match available version in default repositories.
Additionally, macros
rules_scala_toolchain_deps_repositoriesandrules_scala_setupare exported for easier setup of Rules Scala dependencies.Motivation
Without validation it is easy to get wrong version loaded under the impression that
scala_configcontrols dependency versions.For example, such maintenance as in #1434 would get better feedback when Scala version is not properly configured