Add scala_version function #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dinowernli what do you think of this? |
| """return the scala version for use in maven coordinates""" | ||
| return "2.11" | ||
|
|
||
| def scala_mvn_artifact(artifact): |
There was a problem hiding this comment.
I'm wondering, should we really be parsing the artifact and stitching it back together? It seems like it might be more natural to just explicitly pass in the parts, but maybe I'm missing something.
There was a problem hiding this comment.
I agree that such stringly typed code is not great. That said, see:
https://github.com/bazelbuild/rules_scala/pull/15/files#diff-09498dbadf45966909850dc8a47ebb13R9
bazel's maven_jar expects the artifact in one big string.
We saw massive pains at Twitter with pants when we had _2.9.2 baked into artifact names rather than just one function we could update. Want to make sure the same does not happen here.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is related to #14
We give a function
scala_versionand ascala_mvn_artifactthat can be used in name mangling for scala jars. This can help deal with making WORKSPACES less tied to a particular version of scala.