Add support for netrc in jvm_maven_import_external #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`auth=` parameter for `repository_ctx.download` is both required to fetch from private registries and is not well-documented bazelbuild/bazel#13709 (comment) With this change ```python rules_scala_toolchain_deps_repositories( maven_servers = ["some_private_artifactory_url"] ) ``` would be able to authenticate using default .netrc (like `~/.netrc`)
simuons
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
auth=parameter forrepository_ctx.downloadis both required to fetch from private registries and is not well-documented bazelbuild/bazel#13709 (comment)With this change
would be able to authenticate using default .netrc (like
~/.netrc)Motivation
Private maven registry could be useful to host patched versions of libraries or to ensure that there's a private persistent mirror for those artifacts