Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Register proto toolchain for simple usage #1531

Merged
merged 1 commit into from
Dec 4, 2023
Merged

doc: Register proto toolchain for simple usage #1531

merged 1 commit into from
Dec 4, 2023

Conversation

honnix
Copy link
Contributor

@honnix honnix commented Dec 1, 2023 •
edited
Loading

Description

Add default toolchains registration code to scala_proto_library documentation.

Closes #768

Motivation

For a simple usage of scala_proto_library without customization, it seems default toolchains registration must be done, otherwise users will get error like: ERROR: No matching toolchains found for types @io_bazel_rules_scala//scala_proto:toolchain_type.

liucijus
liucijus approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@liucijus liucijus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @honnix!

@simuons simuons merged commit b757df9 into bazelbuild:master Dec 4, 2023
2 checks passed
@honnix honnix deleted the patch-1 branch December 4, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simuons simuons simuons approved these changes

@liucijus liucijus liucijus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no matching toolchains found for types @io_bazel_rules_scala//scala_proto:toolchain_type
3 participants
@honnix @simuons @liucijus