JacocoRunner script: update for Jacoco 0.8.11 and Bazel 7.0.2 #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rules_scala has issues with coverage on JDK 21. Bazel has solved this in bazelbuild/bazel#20845 by upgrading Jacoco and ASM. Added option to build JacocoRunner for Bazel 7, the version with fix will be used with Jacoco interface changes. Jacoco upgraded to 0.8.11 (including the Jacoco/Bazel branches used for that).
|
This is a workaround for #1521, and otherwise also useful upgrade. |
simuons
approved these changes
Apr 9, 2024
|
Even though Bazel 7.1.0 seems to solve the original issue that motivated this upgrade, that release does not have the Jacoco and ASM upgrade when using it for building the jacocorunner. |
So I'll leave the Bazel branch as is. |
liucijus
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules_scala has issues with coverage on JDK 21.
Bazel has solved this in bazelbuild/bazel#20845 by upgrading Jacoco and ASM.
Added option to build JacocoRunner for Bazel 7, the version with fix will be used with Jacoco interface changes.
Jacoco upgraded to 0.8.11 (including the Jacoco/Bazel branches used for that).