Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow transitioning Scala version with scala_version attribute of rules #1569

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

aszady
Copy link
Contributor

@aszady aszady commented Apr 17, 2024

Description

Implements transition and exposes it via the scala_version attribute for a number of common rules.

No effect at the moment, as for now we have only one valid setting.
After allowing more Scala versions when configuring rules repository, this will become the central part of the cross-build.

Motivation

Originally #1290.
Partitioned from #1552.

…ules

Co-authored-by: mkuta <mkuta@virtuslab.com>
Copy link
Collaborator

@simuons simuons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aszady

Copy link
Collaborator

@liucijus liucijus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @aszady!

@liucijus liucijus merged commit 7c5126f into bazelbuild:master Apr 22, 2024
2 checks passed
@aszady aszady deleted the transition branch April 22, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants