Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala 3.4.3 support #1603

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Scala 3.4.3 support #1603

merged 3 commits into from
Sep 9, 2024

Conversation

lm1nrt
Copy link
Contributor

@lm1nrt lm1nrt commented Aug 26, 2024 •
edited
Loading

Description

  • Added artifacts for Scala 3.4.3 version
  • Updated tests that are dependent on the chosen scala version
  • Fixed java.lang.NoClassDefFoundError: xsbti/UseScope for Scala versions >= 3.4.0

Motivation

There are newer versions of Scala that can be supported.

@lm1nrt lm1nrt changed the title scala 3.4.2 support Scala 3.4.2 support Aug 26, 2024
@lm1nrt lm1nrt mentioned this pull request Aug 26, 2024
Open
@lm1nrt lm1nrt marked this pull request as ready for review August 26, 2024 09:34
@lm1nrt lm1nrt marked this pull request as draft August 26, 2024 09:34
@lm1nrt lm1nrt marked this pull request as ready for review August 26, 2024 09:35
@WojciechMazur
Copy link
Contributor

There's a hot-fix release for Scala 3.4.3, I'd recommend targeting that version instead. https://scala-lang.org/news/3.4.3
Also ping for maintainers.

@lm1nrt lm1nrt changed the title Scala 3.4.2 support Scala 3.4.3 support Sep 2, 2024
@lm1nrt
Copy link
Contributor Author

lm1nrt commented Sep 2, 2024

@liucijus @simuons could you take a look at this? Thank you :)

simuons
simuons approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@simuons simuons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lm1nrt

liucijus
liucijus approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@liucijus liucijus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lm1nrt!

@liucijus liucijus merged commit 2d90d53 into bazelbuild:master Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simuons simuons simuons approved these changes

@liucijus liucijus liucijus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lm1nrt @WojciechMazur @simuons @liucijus