Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate jar dependencies of tests from maven_jar to jvm_maven_import_external #871

Closed
wants to merge 5 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test_expect_failure/scala_import/BUILD
  • Loading branch information
jin committed Nov 28, 2019
commit c83b0ad77806108a672b9b49cceffe58f7b78425
8 changes: 4 additions & 4 deletions test_expect_failure/scala_import/BUILD
Original file line number Diff line number Diff line change
@@ -6,18 +6,18 @@ load("//scala:scala_import.bzl", "scala_import")

scala_import(
name = "dummy_dependency_to_trigger_create_provider_transitive_compile_jar_usage",
jars = ["@org_psywerx_hairyfotr__linter//jar:file"],
jars = ["@org_psywerx_hairyfotr__linter//jar"],
)

scala_import(
name = "guava",
jars = ["@com_google_guava_guava_21_0_with_file//jar:file"],
jars = ["@com_google_guava_guava_21_0_with_file//jar"],
deps = [":dummy_dependency_to_trigger_create_provider_transitive_compile_jar_usage"],
)

scala_import(
name = "cats",
jars = ["@org_typelevel__cats_core//jar:file"],
jars = ["@org_typelevel__cats_core//jar"],
)

scala_import(
@@ -28,7 +28,7 @@ scala_import(

scala_import(
name = "commons_lang_as_imported_jar_cats_and_guava_as_compile_deps",
jars = ["@org_apache_commons_commons_lang_3_5//jar:file"],
jars = ["@org_apache_commons_commons_lang_3_5//jar"],
deps = [
":guava",
":indirection_for_transitive_compile_deps",