rename everything rulesscala to rules_scala #970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI error here looks spurious. @ittaiz can you do a rebuild? |
|
@andyscott these should fix all the Maven CI issue #968 #973, and they have been merged. I would try to rebase. |
|
Closing for now. Will bring this back up once all the other changes have settled down. |
|
Thanks!
On Wed, 12 Feb 2020 at 22:38 Andy Scott ***@***.***> wrote:
Closed #970 <#970>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#970?email_source=notifications&email_token=AAKQQF63I3BEQNTHBWSVPFTRCRM4ZA5CNFSM4KM5NNSKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWS7DX4A#event-3032366064>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKQQF27RKUV5IYOUSPJZYTRCRM4ZANCNFSM4KM5NNSA>
.
--
*Ittai Zeidman*
40 Hanamal street, Tel Aviv, Israel
<http://www.wix.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames all rulesscala paths to rules_scala.
Motivation
It always has bothered me that we have both rules_scala and rulesscala paths floating around. This renames everything to rules_scala to be consistent with our project name.