Skip to content

Commit

Permalink
Pass -enable-testing when compiling the sources in a swift_test i…
Browse files Browse the repository at this point in the history
…n discovery mode.

When doing manual discovery, this allows the generated sources to `@testable import` that module even when building with `-c opt`.

PiperOrigin-RevId: 471809177
  • Loading branch information
allevato authored and swiple-rules-gardener committed Sep 2, 2022
1 parent 5da9abd commit 82f828b
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions swift/swift_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,13 @@ def _swift_test_impl(ctx):
# In test discovery mode (whether manual or by the Obj-C runtime),
# compile the code with `-parse-as-library` to avoid the case where
# a single file with no top-level code still produces an empty
# `main`.
additional_copts = ["-parse-as-library"] if discover_tests else [],
# `main`. Also compile with `-enable-testing`, because the generated
# sources will `@testable import` this module, and this allows that
# to work even when building in `-c opt` mode.
additional_copts = [
"-parse-as-library",
"-enable-testing",
] if discover_tests else [],
compilation_contexts = compilation_contexts,
feature_configuration = feature_configuration,
module_name = module_name,
Expand Down

1 comment on commit 82f828b

@brentleyjones
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.