Added target name to output path to support multiple builds of same module #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tymurmustafaiev
requested review from
BalestraPatrick,
brentleyjones,
keith,
segiddins,
thii and
mattrobmattrob
as code owners
tymurmustafaiev
commented
Sep 4, 2023
…builds of same module" (bazelbuild#1097)" This reverts commit bb01c86.
tymurmustafaiev
force-pushed
the
fix-revert-target-name-pr-at-output-path
branch
from
6978d0e to
c739483
Compare
mattrobmattrob
changed the title
tymurmustafaiev
force-pushed
the
fix-revert-target-name-pr-at-output-path
branch
from
9f3a4cc to
423a83e
Compare
…ame-pr-at-output-path # Conflicts: # swift/internal/swift_clang_module_aspect.bzl
keith
approved these changes
Apr 10, 2024
vakhidbetrakhmadov
pushed a commit
to vakhidbetrakhmadov/rules_swift
that referenced
this pull request
May 13, 2024
…odule (bazelbuild#1098) This PR is a revert of bazelbuild#1097 (which was a revert of bazelbuild#1082) with additional fixes 🙏 There was an issue when without enabling the `SWIFT_FEATURE_ADD_TARGET_NAME_TO_OUTPUT` feature, target_name were added to output path of swift binary.
vakhidbetrakhmadov
pushed a commit
to vakhidbetrakhmadov/rules_swift
that referenced
this pull request
May 13, 2024
…odule (bazelbuild#1098) This PR is a revert of bazelbuild#1097 (which was a revert of bazelbuild#1082) with additional fixes 🙏 There was an issue when without enabling the `SWIFT_FEATURE_ADD_TARGET_NAME_TO_OUTPUT` feature, target_name were added to output path of swift binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a revert of #1097 (which was a revert of #1082) with additional fixes 🙏
There was an issue when without enabling the
SWIFT_FEATURE_ADD_TARGET_NAME_TO_OUTPUTfeature, target_name were added to output path of swift binary.