Specify simulator in target triple #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allevato
approved these changes
Mar 8, 2019
allevato
pushed a commit
that referenced
this pull request
Mar 8, 2019
I notice that simulator builds don't have the `-simulator` [environment](http://llvm.org/doxygen/classllvm_1_1Triple.html#a1778f5c464f88710033f7e11e84a9324) in the target triple. With this change, `-simulator` is added for platforms where `is_device` is false. This matches Xcode. Closes #154. RELNOTES: `-simulator` is now added to the target triple passed to `swiftc` (e.g., "-target x86_64-apple-ios10.3-simulator") by the Xcode toolchain when targeting simulator platforms. PiperOrigin-RevId: 237447785
|
I noticed that Bazel's osx crosstool also doesn't include |
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
I notice that simulator builds don't have the `-simulator` [environment](http://llvm.org/doxygen/classllvm_1_1Triple.html#a1778f5c464f88710033f7e11e84a9324) in the target triple. With this change, `-simulator` is added for platforms where `is_device` is false. This matches Xcode. Closes bazelbuild#154. RELNOTES: `-simulator` is now added to the target triple passed to `swiftc` (e.g., "-target x86_64-apple-ios10.3-simulator") by the Xcode toolchain when targeting simulator platforms. PiperOrigin-RevId: 237447785
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I notice that simulator builds don't have the
-simulatorenvironment in the target triple. With this change,-simulatoris added for platforms whereis_deviceis false. This matches Xcode.