Use the target triple from the C++ toolchain instead of deriving it from values in the Apple configuration fragment. #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom values in the Apple configuration fragment. When using `--host_cpu=darwin_x86_64` on an ARM (Apple Silicon) host, the value returned by the Apple configuration fragment is wrong, and we end up compiling Swift for `arm64`. Since the C++ toolchain already has the correct triple verbatim as we want it in the `target_gnu_system_name` field, just use that, and add some generally useful utilities for manipulating the triples and their components. Note to open-source rules maintainers: This change requires/assumes that your C++ toolchain configuration returns a complete target triple that includes minimum OS version and target environment; for example, `x86_64-apple-ios13.0-simulator`. PiperOrigin-RevId: 429897884 (cherry picked from commit 62b33ed)
thii
force-pushed
the
use-the-target-triple-from-the-c-toolchain-instead-of-deriving-it-from-values-in-the-apple-configuration-fragment
branch
from
a4019d5
to
5286ff9
Compare
thii
referenced
this pull request
Feb 24, 2022
…rom values in the Apple configuration fragment. When using `--host_cpu=darwin_x86_64` on an ARM (Apple Silicon) host, the value returned by the Apple configuration fragment is wrong, and we end up compiling Swift for `arm64`. Since the C++ toolchain already has the correct triple verbatim as we want it in the `target_gnu_system_name` field, just use that, and add some generally useful utilities for manipulating the triples and their components. Note to open-source rules maintainers: This change requires/assumes that your C++ toolchain configuration returns a complete target triple that includes minimum OS version and target environment; for example, `x86_64-apple-ios13.0-simulator`. PiperOrigin-RevId: 429897884
thii
added a commit
to thii/bazel
that referenced
this pull request
Feb 24, 2022
includes minimum OS version and target environment This is required for bazelbuild/rules_swift#768
bazel-io
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Mar 28, 2022
…ludes minimum OS version and target environment This is required for bazelbuild/rules_swift#768 Closes #14898. PiperOrigin-RevId: 437770046
thii
added a commit
to thii/bazel
that referenced
this pull request
Apr 15, 2022
…ludes minimum OS version and target environment This is required for bazelbuild/rules_swift#768 Closes bazelbuild#14898. PiperOrigin-RevId: 437770046 (cherry picked from commit 3442179)
thii
added a commit
to thii/bazel
that referenced
this pull request
Apr 18, 2022
…ludes minimum OS version and target environment This is required for bazelbuild/rules_swift#768 Closes bazelbuild#14898. PiperOrigin-RevId: 437770046 (cherry picked from commit 3442179)
ckolli5
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
May 9, 2022
…ludes minimum OS version and target environment (#15266) This is required for bazelbuild/rules_swift#768 Closes #14898. PiperOrigin-RevId: 437770046 (cherry picked from commit 3442179)
|
ah i missed this and took a stab too, #858 we can take yours though, looks like all the linked stuff is at least in 5.2? |
|
Either one is fine. I'm not near a computer in the next few days to rebase this so I guess just take yours? |
|
ok merged that one |
thii
deleted the
use-the-target-triple-from-the-c-toolchain-instead-of-deriving-it-from-values-in-the-apple-configuration-fragment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
--host_cpu=darwin_x86_64on an ARM (Apple Silicon) host, the value returned by the Apple configuration fragment is wrong, and we end up compiling Swift forarm64. Since the C++ toolchain already has the correct triple verbatim as we want it in thetarget_gnu_system_namefield, just use that, and add some generally useful utilities for manipulating the triples and their components.Note to open-source rules maintainers: This change requires/assumes that your C++ toolchain configuration returns a complete target triple that includes minimum OS version and target environment; for example,
x86_64-apple-ios13.0-simulator.PiperOrigin-RevId: 429897884
(cherry picked from commit 62b33ed)