Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Update to nodejs rules 0.31.1 #453

Conversation

gregmagolan
Copy link
Contributor

@gregmagolan gregmagolan commented May 29, 2019

nodejs_binary entry_point is now a label. See release notes https://github.com/bazelbuild/rules_nodejs/releases/tag/0.31.0 for more info.

#455 should land first.

This commit is a pre-req to bazel-contrib/rules_nodejs#777

@gregmagolan gregmagolan changed the title Update nodejs_binary entry points to labels WIP: Update nodejs_binary entry points to labels May 29, 2019
@gregmagolan gregmagolan force-pushed the nodejs-binary-entry-point-labels branch from fd96710 to 977ad67 Compare June 2, 2019 18:29
@gregmagolan
Copy link
Contributor Author

gregmagolan commented Jun 2, 2019

Need rules_nodejs snapshot builds of npm packages to fix the error here that target is using jasmine_node_test out of @bazel/jasmine:

ERROR: /workdir/internal/BUILD.bazel:115:1: //internal:test: invalid label '@bazel/jasmine/src/jasmine_runner.js' in attribute 'entry_point' in 'nodejs_test' rule: invalid repository name '@bazel/jasmine/src/jasmine_runner.js': workspace names may contain only A-Z, a-z, 0-9, '-', '_' and '.'
--
  | ERROR: /workdir/internal/BUILD.bazel:115:1: //internal:test: missing value for mandatory attribute 'entry_point' in 'nodejs_test' rule
  | ERROR: package contains errors: internal
  | WARNING: Target pattern parsing failed.
  | INFO: Build option --legacy_external_runfiles has changed, discarding analysis cache.
  | ERROR: /workdir/internal/BUILD.bazel:137:1: Target '//internal:common/compilation.bzl' contains an error and its package is in error and referenced by '//internal:npm_package_assets'
  | ERROR: /workdir/internal/BUILD.bazel:137:1: Target '//internal:common/json_marshal.bzl' contains an error and its package is in error and referenced by '//internal:npm_package_assets'
  | ERROR: /workdir/internal/BUILD.bazel:137:1: Target '//internal:common/module_mappings.bzl' contains an error and its package is in error and referenced by '//internal:npm_package_assets'
  | ERROR: /workdir/internal/BUILD.bazel:137:1: Target '//internal:common/tsconfig.bzl' contains an error and its package is in error and referenced by '//internal:npm_package_assets'
  | ERROR: /workdir/internal/BUILD.bazel:26:1: Target '//internal:common/compilation.bzl' contains an error and its package is in error and referenced by '//internal:bzl'
  | ERROR: /workdir/internal/BUILD.bazel:26:1: Target '//internal:common/json_marshal.bzl' contains an error and its package is in error and referenced by '//internal:bzl'
  | ERROR: /workdir/internal/BUILD.bazel:26:1: Target '//internal:common/module_mappings.bzl' contains an error and its package is in error and referenced by '//internal:bzl'
  | ERROR: /workdir/internal/BUILD.bazel:26:1: Target '//internal:common/tsconfig.bzl' contains an error and its package is in error and referenced by '//internal:bzl'

@gregmagolan gregmagolan force-pushed the nodejs-binary-entry-point-labels branch from 977ad67 to 586ec25 Compare June 2, 2019 19:48
@gregmagolan gregmagolan force-pushed the nodejs-binary-entry-point-labels branch 3 times, most recently from 6521ce4 to 69db675 Compare June 6, 2019 22:45
@gregmagolan gregmagolan changed the title WIP: Update nodejs_binary entry points to labels Update to nodejs rules 0.31.0 Jun 6, 2019
@gregmagolan gregmagolan force-pushed the nodejs-binary-entry-point-labels branch from 69db675 to bc7b3d3 Compare June 6, 2019 22:50
@gregmagolan gregmagolan changed the title Update to nodejs rules 0.31.0 WIP: Update to nodejs rules 0.31.0 Jun 6, 2019
@gregmagolan gregmagolan force-pushed the nodejs-binary-entry-point-labels branch from bc7b3d3 to 5a6b04f Compare June 7, 2019 16:11
@gregmagolan gregmagolan changed the title WIP: Update to nodejs rules 0.31.0 Update to nodejs rules 0.31.1 Jun 7, 2019
nodejs_binary entry_point is now a label
@gregmagolan gregmagolan force-pushed the nodejs-binary-entry-point-labels branch from 5a6b04f to 7389ce2 Compare June 7, 2019 16:43
@alexeagle alexeagle closed this in 66505d1 Jun 7, 2019
gregmagolan added a commit to gregmagolan/rules_nodejs that referenced this pull request Jun 10, 2019
alexeagle pushed a commit to bazel-contrib/rules_nodejs that referenced this pull request Jun 10, 2019
siberex pushed a commit to siberex/rules_nodejs that referenced this pull request Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants