This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 94
Update to nodejs rules 0.31.1 #453
Closed
gregmagolan
wants to merge
1
commit into
bazelbuild:master
from
gregmagolan:nodejs-binary-entry-point-labels
Closed
Update to nodejs rules 0.31.1 #453
gregmagolan
wants to merge
1
commit into
bazelbuild:master
from
gregmagolan:nodejs-binary-entry-point-labels
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
changed the title
Update nodejs_binary entry points to labels
WIP: Update nodejs_binary entry points to labels
May 29, 2019
gregmagolan
force-pushed
the
nodejs-binary-entry-point-labels
branch
from
June 2, 2019 18:29
fd96710
to
977ad67
Compare
Need rules_nodejs snapshot builds of npm packages to fix the error here that target is using
|
gregmagolan
force-pushed
the
nodejs-binary-entry-point-labels
branch
from
June 2, 2019 19:48
977ad67
to
586ec25
Compare
Merged
12 tasks
gregmagolan
force-pushed
the
nodejs-binary-entry-point-labels
branch
3 times, most recently
from
June 6, 2019 22:45
6521ce4
to
69db675
Compare
gregmagolan
changed the title
WIP: Update nodejs_binary entry points to labels
Update to nodejs rules 0.31.0
Jun 6, 2019
gregmagolan
force-pushed
the
nodejs-binary-entry-point-labels
branch
from
June 6, 2019 22:50
69db675
to
bc7b3d3
Compare
gregmagolan
changed the title
Update to nodejs rules 0.31.0
WIP: Update to nodejs rules 0.31.0
Jun 6, 2019
gregmagolan
force-pushed
the
nodejs-binary-entry-point-labels
branch
from
June 7, 2019 16:11
bc7b3d3
to
5a6b04f
Compare
gregmagolan
changed the title
WIP: Update to nodejs rules 0.31.0
Update to nodejs rules 0.31.1
Jun 7, 2019
nodejs_binary entry_point is now a label
gregmagolan
force-pushed
the
nodejs-binary-entry-point-labels
branch
from
June 7, 2019 16:43
5a6b04f
to
7389ce2
Compare
gregmagolan
added a commit
to gregmagolan/rules_nodejs
that referenced
this pull request
Jun 10, 2019
alexeagle
pushed a commit
to bazel-contrib/rules_nodejs
that referenced
this pull request
Jun 10, 2019
siberex
pushed a commit
to siberex/rules_nodejs
that referenced
this pull request
Jun 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodejs_binary entry_point is now a label. See release notes https://github.com/bazelbuild/rules_nodejs/releases/tag/0.31.0 for more info.
#455 should land first.
This commit is a pre-req to bazel-contrib/rules_nodejs#777