This repository has been archived by the owner on Sep 15, 2021. It is now read-only.
Implementing extracting symbols from load()s and adding them to stubs. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienmg
approved these changes
Jan 11, 2017
| @@ -1,4 +1,4 @@ | |||
| # Copyright 2016 The Bazel Authors. All rights reserved. | |||
| # Copyright 2017 The Bazel Authors. All rights reserved. | |||
There was a problem hiding this comment.
Do not update the date on existing file.
This change adds LoadExtractor, which walks the AST of the .bzl file and extracts information from the load() statements about symbols that are loaded from other .bzl files. These symbols are then added to the set of global stubs in RuleDocExtractor so that, as a first step, if any of these symbols loaded from other .bzl files are referenced in the global scope, Skydoc would not raise a NameError.
|
Thanks for reviewing, @damienmg! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds LoadExtractor, which walks the AST of the .bzl file and
extracts information from the load() statements about symbols that are loaded
from other .bzl files. These symbols are then added to the set of global stubs
in RuleDocExtractor so that, as a first step, if any of these symbols loaded
from other .bzl files are referenced in the global scope, Skydoc would not
raise a NameError.
Issue #21