Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement test runner and add Java's test data #49

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Implement test runner and add Java's test data #49

merged 1 commit into from
Jun 5, 2019

Conversation

Quarz0
Copy link
Contributor

@Quarz0 Quarz0 commented Jun 2, 2019

Related: #10

@Quarz0 Quarz0 requested a review from laurentlb as a code owner June 2, 2019 12:21
@Quarz0
Implement test runner and add Java's test data
87a5031 
Test cases that fail in 1 or more implementation due to inconsistencies
are commented.
laurentlb
laurentlb approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@laurentlb laurentlb merged commit 2600bb6 into bazelbuild:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentlb laurentlb laurentlb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quarz0 @laurentlb