Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default scan directory for the Ubuntu package #10

Closed
GnomoP opened this issue Apr 12, 2018 · 10 comments · Fixed by #27 or #40
Closed

Change the default scan directory for the Ubuntu package #10

GnomoP opened this issue Apr 12, 2018 · 10 comments · Fixed by #27 or #40
Assignees
Labels
bug:resolved Something wasn't working but has been fixed enhancement:feature New feature or request

Comments

@GnomoP
Copy link

GnomoP commented Apr 12, 2018

When installed through the .deb package, which most Ubuntu and Ubuntu derivatives users do, Discord is installed in /usr/share, instead of in /opt like in the Arch package. Changing the default scan directory for the package distributed at the ppa would be a nice tweak to have out-of-the-box, though it isn't anything mind-bogging. Great script, btw

@ObserverOfTime
Copy link
Collaborator

I could change the scan directory for the PPA, but is it a good idea for the script on the PPA to behave differently than the one here?

@bb010g
Copy link
Owner

bb010g commented Apr 12, 2018

Could you give the full path for Discord under /usr/share?

@GnomoP
Copy link
Author

GnomoP commented Apr 12, 2018

It's just /usr/share/discord

@ObserverOfTime
Copy link
Collaborator

I thought of a way to avoid having differences between the packages.
Debian and its derivatives, including Ubuntu and its own derivatives, have /etc/debian_version and/or /etc/debian_release. We could check whether they exist and change the scan location to /usr/share if they do.

@ObserverOfTime
Copy link
Collaborator

@bb010g Should we implement this? What do you think?

@ObserverOfTime ObserverOfTime added the discussion Needs to be discussed label Apr 20, 2018
@ObserverOfTime ObserverOfTime added enhancement:feature New feature or request and removed discussion Needs to be discussed labels Oct 19, 2018
@ObserverOfTime ObserverOfTime added this to the Next milestone Oct 19, 2018
@piks
Copy link
Contributor

piks commented Feb 3, 2019

This issue was closed, and it seems some code was added to attempt this but mine still doesn't detect my installation(was going to open a seperate issue but, github was like "hey there might already be a ticket on this!")

pika@pika-mint /usr/local/bin $ betterdiscordctl -f PTB
ERROR: Discord installation not found.
pika@pika-mint /usr/local/bin $ betterdiscordctl -s /usr/share -f PTB
Discord: /usr/share/discord-ptb
Modules: /home/pika/.config/discordptb/0.0.13/modules
Core patched: yes
Index modified: yes
Linked core directory: /home/pika/.local/share/betterdiscordctl/bd/0
Linked core repository: https://github.com/rauenzi/BetterDiscordApp
pika@pika-mint /usr/local/bin $ betterdiscordctl -V
betterdiscordctl 1.5.0
pika@pika-mint /usr/local/bin $

@ObserverOfTime ObserverOfTime reopened this Feb 3, 2019
@ObserverOfTime
Copy link
Collaborator

Right, looks like it doesn't work properly after all...

@ObserverOfTime ObserverOfTime added the bug:unresolved Something isn't working label Feb 3, 2019
bb010g added a commit that referenced this issue Feb 20, 2019
@ObserverOfTime
Copy link
Collaborator

@piks Please try the latest master.

@piks
Copy link
Contributor

piks commented May 29, 2019

pika@pika-mint ~/bot/nodev3 $ betterdiscordctl --version
betterdiscordctl 1.6.0

pika@pika-mint ~/bot/nodev3 $ betterdiscordctl status
ERROR: Discord installation not found.

pika@pika-mint ~/bot/nodev3 $ betterdiscordctl status -f PTB
ERROR: Discord installation not found.

pika@pika-mint ~/bot/nodev3 $ betterdiscordctl status -f PTB -s /usr/share
Discord: /usr/share/discord-ptb
Modules: /home/pika/.config/discordptb/0.0.15/modules
Index modified: no
Linked injector directory: no
Linked injector repository: no

@ObserverOfTime
Copy link
Collaborator

Well, we'll fix it eventually.

@ObserverOfTime ObserverOfTime removed this from the next milestone May 29, 2019
@ObserverOfTime ObserverOfTime pinned this issue May 29, 2019
piks added a commit to piks/betterdiscordctl that referenced this issue May 29, 2019
changes the variable on line 280 to match the variable that is recursed through the directory (previously was stuck as /opt since that is what $scan was, $scandir is the variable it was expecting.
fixes bb010g#10
ObserverOfTime added a commit that referenced this issue May 29, 2019
changes the variable on line 280 to match the variable that is recursed through the directory (previously was stuck as /opt since that is what $scan was, $scandir is the variable it was expecting.
fixes #10
@ObserverOfTime ObserverOfTime unpinned this issue May 29, 2019
@ObserverOfTime ObserverOfTime removed the bug:unresolved Something isn't working label Feb 24, 2022
@ObserverOfTime ObserverOfTime added the bug:resolved Something wasn't working but has been fixed label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:resolved Something wasn't working but has been fixed enhancement:feature New feature or request
Projects
None yet
4 participants