Strange indentation error with if/else alignment

[zmoazeni]

Ruby code:

bar = true

some_var = if bar
  "it's true!"
else
  "it's not true"
end

puts some_var

rubocop config:

Style/ElseAlignment:
  Enabled: false

Lint/EndAlignment:
  Enabled: false

Error message:

foo.rb:4:3: C: Use 2 (not -9) spaces for indentation.
  "it's true!"
  ^^^^^^^^^

---

If I don't want to enforce if/else formats, how can I disable this without getting a warning?

[bquorning]

Yeah, that’s a bit weird. The warning comes from the Style/IndentationWidth cop, but it actually looks at the Lint/EndAlignment configuration in this case.

To fix it, you would either disable Style/IndentationWidth, or enable Lint/EndAlignment with the configuration

Lint/EndAlignment:
  AlignWith: variable

[zmoazeni]

To fix it, you would either disable Style/IndentationWidth

Wouldn't this disable indentation checking across the board? Ignoring stuff like:

def foo
    1 # 4 spaces
end

or enable Lint/EndAlignment with the configuration

Like I said, we don't want to enforce if/else alignment rules. If we choose variable then it doesn't allow:

some_var =
  if bar
    "it's true!"
  else
    "it's not true"
  end

[jonas054]

I think the variable style of Lint/EndAlignment should be changed so that it accepts (enforces) alignment with the if keyword in the above example where there is a line break after =.

[bbatsov]

I think the variable style of Lint/EndAlignment should be changed so that it accepts (enforces) alignment with the if keyword in the above example where there is a line break after =.

Definitely.

[patbl]

So is it not possible to allow both

some_var = if bar
             "it's true!"
           else
             "it's not true"
           end

and

some_var = if bar
  "it's true!"
else
  "it's not true"
end

with Layout/IndentationWidth enabled?

[jonas054]

No. Allowing two styles is generally not something we like to do in RuboCop. It's either/or.