@joeyAghion => Ability to sort on the index views #migration

[sweir27]

cc @nicoleyeo

This PR adds the ability to sort on the submissions, offers, and consignments index views.

Each sortable header is a link to a specified sort field/direction.

I also took the opportunity to do a little cleanup in the controllers to use decent_exposure instead of setting instance variables. I've really come to like this pattern! (cc @jonallured). Not everything is switched over, but I'm updating things as they are relevant.

Migration

Submission.pluck(:id).each do |sub_id|
  Submission.reset_counters(sub_id, :offers)
end; nil

[sweir27]

You'll notice this in a bunch of controllers-- instead of setting the @page and @size variables in the base controller, we now use decent_exposure and they are lazy-loaded.

(Note that there's probably a way with kaminari to paginate without having to set these at all, but since we're using the kinetic UI it does require a page and size to be passed in still, so we must set them).

[sweir27]

This will keep an offers_count on a submission.

[sweir27]

A little refactor here-- the partials now require an individual artist to be passed in instead of inferring it from the @artist_details hash.

[sweir27]

Because we are now passing an artist per-item, I had to break this out.

On a side note, I actually like this a little better since it's easier to search for where partials are being used.

[jonallured]

Yay!! Excited to see decent_exposure being used at Artsy!! 🎉

Reading through this PR, one thing jumps out at me - the length of the consignments exposure in ConsignmentsController. I wonder if there's a refactor here to extract an object. I see a phrase here, matching consignments, that I'm guessing could be good to pull out as a domain concept. I would love to pair on this, but my quick back-of-the-napkin idea is something more like this:

expose(:matching_consignments) do
  MatchingConsignments.find(params, @page, @size)
end

And then pull all the business logic from the existing exposure there. That would mean those nice controller specs you've written could be moved over there as well. Open to other ideas, my main point is simply that the controller is doing too much work here, knows too much. I think extracting an object that it can collaborate with would be a big win!

[joeyAghion]

Arbitrary indentation makes me crazy, even if rubocop likes it. Consider disabling the offense, or switching its mode to support the line-broken style:

x =
  if ...

[joeyAghion]

I'm OK w/this when you want to merge...