chore: make sure elapsedTime is on response and unit tested

bbc · Oct 9, 2023 · dc3ea44 · dc3ea44
1 parent 26415a8
commit dc3ea44
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/lib/transport/node-fetch.js b/lib/transport/node-fetch.js
@@ -7,6 +7,7 @@ const HttpProxyAgent = require('http-proxy-agent').HttpProxyAgent;
 const fetch = require('node-fetch');
 
 const REQUIRED_PROPERTIES = [
+  'elapsedTime',
   'url',
   'statusCode',
   'headers'
@@ -35,7 +36,7 @@ class FetchTransport extends Transport {
 
     opts.timeout = req.getTimeout() || this.defaults?.timeout;
     opts.compress = this.defaults?.compress;
-    if (opts.time === undefined) opts.time = true;
+    if (this.defaults?.time === undefined) opts.time = true;
 
     if (req.hasQueries()) opts.searchParams = new URLSearchParams(req.getQueries());
 

diff --git a/test/transport/node-fetch.js b/test/transport/node-fetch.js
@@ -246,6 +246,26 @@ describe('Request HTTP transport', () => {
         .catch(assert.ifError);
     });
 
+    it('allows disabling of  timing request', () => {
+      nock.cleanAll();
+      api.get('/').reply(200, responseBody);
+
+      const ctx = createContext(url);
+      const options = {
+        defaults: {
+          time: false
+        }
+      };
+
+      return new FetchTransport(options)
+        .execute(ctx)
+        .then((ctx) => {
+          const timeTaken = ctx.res.elapsedTime;
+          assert.isUndefined(timeTaken);
+        })
+        .catch(assert.ifError);
+    });
+
     describe('JSON parsing', () => {
       it('if json default option is passed in as true, parse body as json', () => {
         nock.cleanAll();