Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPLAYER-44041: Handle multiple query parameters without index #49

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

sbason
Copy link
Contributor

@sbason sbason commented Feb 8, 2024

Description

This removes the indexes when multiple query parameters are added to allow for maximum compatibility with APIs

Motivation and Context

Not all APIs support indexes when multiple query parameters are used.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
    - [ ] My change requires a change to the documentation.
    - [ ] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sbason sbason requested a review from a team as a code owner February 8, 2024 17:03
@JohnNewman1 JohnNewman1 merged commit 172469c into bbc:main Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants