Fix numpy VideoGrain.length to be the byte length #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipnbbc
force-pushed
the
philipn-numpy-data-len
branch
from
a289611 to
3ffa7f0
Compare
jamesba
approved these changes
Jan 30, 2020
philipnbbc
force-pushed
the
philipn-numpy-data-len
branch
from
3ffa7f0 to
31c39c9
Compare
philipnbbc
force-pushed
the
philipn-numpy-data-len
branch
from
31c39c9 to
379c9bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue resulted in a grain converted to v210 and written to GSF to have an incorrect size in the
grdtblock header.The
# type: ignorewas required because mypy reportedmediagrains/numpy/videograin.py:254: error: overloaded function has no attribute "fset". There is an open mypy issue related to this: python/mypy#6045.Found as part of pivotal job https://www.pivotaltracker.com/story/show/169632693