Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie redirects do not work on mobile and desktop #5038

Closed
1 task
Bopchy opened this issue Jan 6, 2020 · 6 comments
Closed
1 task

Cookie redirects do not work on mobile and desktop #5038

Bopchy opened this issue Jan 6, 2020 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@Bopchy
Copy link
Contributor

Bopchy commented Jan 6, 2020

Describe the bug
Cookie redirects do not work on mobile devices and desktop browsers. This is likely because cookies that are not getting set on desktop and on mobile.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to http://localhost:7080/serbian on a mobile device/desktop browser. The page should navigate to http://localhost:7080/serbian/lat
  2. Click on the script link in the top right hand corner of the banner. This should cause the page to navigate to http://localhost:7080/serbian/cyr
  3. Click on the Brand svg
  4. See error (the page should load http://localhost:7080/serbian/cyr and not http://localhost:7080/serbian/lat)

Expected behavior
On Desktop browsers/mobile devices, clicking on the brand svg after clicking on the script link should load chosen variant page, not default.

Screenshots
script_link_mobile

Testing notes

  • This bug fix is expected to need manual testing.

Additional context
This issue is only on mobile devices. Desktop works as expected.

@Bopchy Bopchy added bug Something isn't working Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. simorgh-core-stream labels Jan 6, 2020
@Bopchy Bopchy added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Jan 6, 2020
@Bopchy
Copy link
Contributor Author

Bopchy commented Jan 6, 2020

Needs #4948 and #4833 to be merged

@PriyaKR PriyaKR changed the title Cookie redirects do not work on mobile Cookie redirects do not work on mobile and desktop Jan 7, 2020
@tochwill
Copy link
Contributor

tochwill commented Jan 8, 2020

#4948 is merged into the feature branch now - I think we should look at this before we merge the feature branch to latest?

@tochwill tochwill removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Jan 8, 2020
@tochwill
Copy link
Contributor

tochwill commented Jan 8, 2020

Is this the same as Service variant not respected on initial render #4976 - or does the page not re-render at all? I've tried this locally and I see the behaviour described in that bug ticket.

@tochwill tochwill removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Jan 13, 2020
@Bopchy Bopchy self-assigned this Jan 13, 2020
@Bopchy
Copy link
Contributor Author

Bopchy commented Jan 13, 2020

On mobile, the page does not re-render

@Bopchy
Copy link
Contributor Author

Bopchy commented Jan 13, 2020

This issue is being caused by client-side javascript not loading when the hostname is not localhost on test devices. Because the redirect is happening on the client as mentioned here, if the client's javascript does not load, then the redirect will not work

@Bopchy
Copy link
Contributor Author

Bopchy commented Jan 22, 2020

Closing this as this is not really a bug, but an issue caused with how testing gets done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants