-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Brand with Script Link component on services with variants #4948
Use Brand with Script Link component on services with variants #4948
Conversation
…o integrate-new-navigation
…o 4009-use-brand-with-script-link
…nt to be switched to.
…o 4009-use-brand-with-script-link
Testing: Noticed few issues across cross browser and device testing
|
Seeing |
@Bopchy i see the IE9 issue happening on wider screens. |
The IE9 issue (pictured below) is happening because IE9 doesn't fully support Will not be fixing this though as IE9 is not on the list of supported browsers |
This should be fixed in #5038 |
…o 4009-use-brand-with-script-link
…o 4009-use-brand-with-script-link
…o 4009-use-brand-with-script-link
Travis failures will be fixed in https://github.com/bbc/simorgh/tree/integrate-new-navigation once this work is merged, as the same failures are happening in parent branch as well |
@Bopchy I am now seeing the mobile issue mentioned above on desktop as well.May be we should tweak the issue saying |
I have updated the issue #5038 to include the desktop issue as well.So this PR can be merged now as separate issue is being created for the bugs mentioned above. |
Resolves #4009
Overall change:
Use Brand with ScriptLink component on services with variants.
Code changes:
Testing:
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive
)