Integrate canonical navigation animation #5057
Conversation
|
Jenkins is failing on rendering a Brand with a Skip to content link. However, that issue is being fixed in #4948 . |
| @@ -30,6 +30,14 @@ describe('defaultPageWrapper', () => { | |||
| }, | |||
| }; | |||
|
|
|||
| window.matchMedia = jest.fn().mockImplementation(() => { | |||
There was a problem hiding this comment.
I think we can skip this since we won't need the hook once we pull in the changes in this PR BBC-archive/psammead#2875
There was a problem hiding this comment.
Good point, removed it
|
Testing: Have verified the changes that have gone in this integration.Looks good except the navigation dropdown menu doesn't animate on ios device(tested on ios 13,12). |
Thank you Priya! Looking into it now. |
|
The ios issue would be fixed in a separate PR and its good to merge. |
|
Ticket for the IOS issue that will be dealt with separately: BBC-archive/psammead#2898 |
Resolves #NUMBER
Overall change:
Pull in new version of navigation from Psammead and add canonical animation to the new navigation.
Code changes:
Testing:
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive)