Hoc loading error states #1589
Merged
Hoc loading error states #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner for all three article states
…the RequestContext & ServiceContext
chris-hinds
commented
Apr 12, 2019
dr3
reviewed
Apr 12, 2019
sareh
reviewed
Apr 12, 2019
chris-hinds
commented
Apr 12, 2019
chris-hinds
commented
Apr 12, 2019
dr3
suggested changes
Apr 14, 2019
jamesdonoh
previously approved these changes
Apr 29, 2019
There was a problem hiding this comment.
The tests as they stand provide enough coverage against breakage, let's raise a separate issue to improve them further if needed - this work is a blocker for others and we need to finish it up. Thanks @hindsc52 for taking this on and everyone for their reviews.
|
Blocked by #1661 |
chris-hinds
dismissed stale reviews from dr3, jamesdonoh, and rossgaskell
via
5f64100
|
Please note the current CC issues are for tests so can be ignored. |
rossgaskell
approved these changes
May 13, 2019
|
LGTM. Happy for this to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1248
Overall change:
This PR branches from @sareh original MVP loading state, with the intention of making the Loading and error states more re-useable when adding different page types.
This is done by using HOC (Higher Order Components) to provide a loading and an error state. This enables to reduce of a lot of complexity in the article container and in the future homepage container, removing the need for these to know about error and loading states.
It also introduces a
PageWrapperthat is used to load the necessary page furniture which should be fairly similar if not the same across articles and homepages.I would want to refactor this some more at a later date by producing a Layout that then wraps each page type container, again reducing the required logic in both the article and the homepage containers.
Code changes: