Re-enable nocycle linting #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossgaskell
requested review from
jamesbhobbs,
dr3,
chris-hinds,
jamesdonoh,
pjlee11 and
sareh
as code owners
chris-hinds
reviewed
May 13, 2019
src/server/index.jsx
Outdated
| @@ -38,6 +39,8 @@ class LoggerStream { | |||
|
|
|||
| const server = express(); | |||
|
|
|||
| console.log(routes, articleRegexPath); | |||
There was a problem hiding this comment.
Console.log left in place
|
Hi @rossgaskell thanks, this looks good, just for posterity and the next person scratching their head over any similar warnings can you briefly summarise why "Move route regex to separate file" fixed the linter error? |
jamesdonoh
approved these changes
May 15, 2019
|
No problem, I'll add my investigation notes from the issue |
chris-hinds
approved these changes
May 17, 2019
|
Looks good to me.No more linting errors seen when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1622
Overall change: Re-enable no-cycle linting errors
Code changes:
Investigation
The errors started appearing due to the bump in eslint import plugin version. There was a bug with the babel-eslint parser not reporting the errors. The errors reported already existed before the dependency update in #1597, but were not reported.
import-js/eslint-plugin-import#1218
import-js/eslint-plugin-import#1166
The warnings are a false negative. Whilst there is a circular dependancy due to the internal link requiring the routes regex to match against, this only imports a constant and therefore isn't a true circular dependency.
However to improve readability, the regex paths have been moved to separate file that the routes and internal link component can share without eslint flagging a circular dependency.