force resolve web-vitals 1.1.1 #9153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroebu14
added
cross-team
ryanmccombe
approved these changes
Jun 2, 2021
HarveyPeachey
approved these changes
Jun 2, 2021
This was referenced Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall change:
Force resolves web-vitals version 1.1.1.
getEntriesByNamewas added in 1.1.2 GoogleChrome/web-vitals@4dfde19We think this has broken Opera Mini Extreme mode because
getEntriesByNameis not supported in Opera.UPDATE
This fixed the Opera Mini Extreme mode issue.
cross-teamlabel to this PR if it requires visibility across World Service teamsTesting:
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)