Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SQS Region config value optional. #3

Merged
merged 4 commits into from
May 18, 2015
Merged

Conversation

james075
Copy link

As it is already specified on SQS instance creation like:

// Init AWS credentials
AWS.config.update({
        accessKeyId: process.env.AWS_ACCESS_KEY,
        secretAccessKey: process.env.AWS_ACCESS_SECRET,
        region: process.env.AWS_ACCESS_REGION
    });

// Init SQS service
var sqs = new AWS.SQS();
...

and used as:

    var app = Consumer.create({
        queueUrl: queues.smtp.QueueUrl,
        sqs: sqs,
        handleMessage: function (message, done) {
            // do some work with `message`
            done();
        }
    });

@robinjmurphy
Copy link
Contributor

This is great thanks! Would you be able to update the README here to state that the region is now optional and that the default is 'eu-west-1'?

@james075
Copy link
Author

Yes sure ! ;)

Sent from Outlookhttp://taps.io/outlookmobile

On Mon, May 18, 2015 at 2:01 AM -0700, "Robin Murphy" <notifications@git.luolix.topmailto:notifications@github.com> wrote:

This is great thanks! Would you be able to update the README herehttps://github.com/bbc/sqs-consumer#options to state that the region is now optional and that the default is 'eu-west-1'?

Reply to this email directly or view it on GitHubhttps://github.com//pull/3#issuecomment-102981433.

@robinjmurphy
Copy link
Contributor

Thanks for the README update.

robinjmurphy added a commit that referenced this pull request May 18, 2015
Make SQS Region config value optional.
@robinjmurphy robinjmurphy merged commit aa76830 into bbc:master May 18, 2015
@robinjmurphy
Copy link
Contributor

Published as 2.1.2.

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants