Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade nodejs to maintenance and lts (18 and 20) #734

Merged
merged 2 commits into from
Oct 16, 2024
Merged

chore: upgrade nodejs to maintenance and lts (18 and 20) #734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2162f83
chore: bump github work node versions to latest maintenance and lts (…
yakca Oct 14, 2024
36b8176
chore: upgrade build image to node 20
yakca Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
version: [16, 18]
version: [18, 20]

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ The [examples code](https://github.com/bbc/storyplayer/blob/main/examples/main.j
Building the library from the repo
==================================

> Ensure you have NodeJS v16 installed.
> Ensure you have NodeJS v20 installed.
> We use NPM for dependency management and building.\
> We have an ESLint file based on the `typescript-eslint` parser.\
> We have moved from Flow to TypeScript for type-checking, albeit the types are fairly permissive.
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: '3.5'

services:
storyplayer-dev:
image: node:16
image: node:20
user: ${DOCKER_USER_ID:-node}
working_dir: /storyplayer
environment:
Expand Down
40 changes: 29 additions & 11 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"homepage": "https://github.com/bbc/storyplayer#readme",
"devDependencies": {
"@bbc/object-based-media-schema": "^1.0.4",
"@types/node": "^18.11.18",
"@types/node": "^20.16.11",
"@typescript-eslint/eslint-plugin": "^5.48.0",
"@typescript-eslint/parser": "^5.48.0",
"concurrently": "^5.3.0",
Expand Down
Loading