Fix compatibility with older versions of Ruby (< 1.9.2). #2

Kami · 2013-07-31T13:56:17Z

Currently "compare_images" tasks fail when using Ruby < 1.9.3, because File.write is only available in Ruby 1.9.3 and above:

rake aborted!
undefined method `write' for File:Class
/wraith/Rakefile:72
Tasks: TOP => default => compare_images
(See full trace by running task with --trace

This pull requests fixes that and uses a method which is also available in older versions.

Reference:

Ruby 1.9.3 http://ruby-doc.org/core-1.9.3/IO.html#method-c-write
Ruby 1.9.3 http://ruby-doc.org/core-1.9.2/IO.html#method-c-write (there is no IO.write method)

File.write (IO.write) is only available in Ruby 1.9.3 and above.

sthulb · 2013-07-31T14:13:56Z

@Kami Thanks for the pull request :)

We intentionally made it > 1.9.3 due to EOL for 1.8.7, but we'll merge this in 👍

sthulb · 2013-07-31T14:14:56Z

Rakefile

-    end
-
+
+    File.open("data.txt", "w") do |file| file.write(contents) end


Can you convert do/end to braces please?

Sure, is 8e0cf6f better?

Kami · 2013-07-31T14:23:31Z

@sthulbourn Thanks!

dblooman · 2013-07-31T14:30:41Z

Our first pull request

Fix compatibility with older versions of Ruby (< 1.9.2).

Use a write method which is compatible with older Ruby versions.

96a5259

File.write (IO.write) is only available in Ruby 1.9.3 and above.

sthulb reviewed Jul 31, 2013
View reviewed changes

Use curly braces instead.

8e0cf6f

dblooman added a commit that referenced this pull request Jul 31, 2013

Merge pull request #2 from Kami/fix_ruby_compatibility

594f407

Fix compatibility with older versions of Ruby (< 1.9.2).

dblooman merged commit 594f407 into bbc:master Jul 31, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix compatibility with older versions of Ruby (< 1.9.2). #2

Fix compatibility with older versions of Ruby (< 1.9.2). #2

Kami commented Jul 31, 2013

sthulb commented Jul 31, 2013

sthulb Jul 31, 2013

Kami Jul 31, 2013

Kami commented Jul 31, 2013

dblooman commented Jul 31, 2013

		end


		File.open("data.txt", "w") do \|file\| file.write(contents) end

Fix compatibility with older versions of Ruby (< 1.9.2). #2

Fix compatibility with older versions of Ruby (< 1.9.2). #2

Conversation

Kami commented Jul 31, 2013

sthulb commented Jul 31, 2013

sthulb Jul 31, 2013

Choose a reason for hiding this comment

Kami Jul 31, 2013

Choose a reason for hiding this comment

Kami commented Jul 31, 2013

dblooman commented Jul 31, 2013