Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated gallery page #302

Merged
merged 6 commits into from
Nov 5, 2015
Merged

Updated gallery page #302

merged 6 commits into from
Nov 5, 2015

Conversation

ryandowd
Copy link
Contributor

Config.yaml has three new variables:

thumb_width: 200
thumb_height: 400
slideshow: true

Gallery.rb checks if 'slideshow' is true and points to gallery_template_slideshow.rb to build updated gallery. New gallery includes:

  • All comparisons are in a slideshow (Cycle JS) with prev/next buttons and also slide when clicked from left sidebar nav
  • Left sidebar nav highlights which url is being viewed and also adds 'green tick' when all viewed
  • Under 'new' and 'old' slide there is a link to the respective urls (opens in a new window)
  • Each thumb, when clicked, opens in a new window
  • Next to each threshold percent is a 'file comparison' button. When clicked all full images (new, old, diff) are loaded into a modal overlay which is scrollable

Hope you consider my changes.

Regards,

Ryan

@dblooman
Copy link
Contributor

What does the finished output look like?

@ryandowd
Copy link
Contributor Author

New updated gallery on a desktop

wraith-gallery-slideshow-updates

When 'compare' icon clicked all three full sized images are loaded into a modal which is scrollable

wraith-gallery-slideshow-updates-diff-modal-1

From there all diffs can be compared side by side

wraith-gallery-slideshow-updates-diff-modal-2

Example of a 768px test

wraith-gallery-slideshow-updates_768

Example of a 768px test viewing diffs in modal

wraith-gallery-slideshow-updates_768_modal

@ChrisBAshton
Copy link
Contributor

@ryandowd this looks really promising! Could you fix the conflicts, and also remove 'wraith-2.6.0.gem' from the PR?

I also suggest a tweak to your config additions - the new gallery becomes the default, but (optionally) you can customise your theme through the YAML file like this:

gallery:
  - thumb_width:   200
  - thumb_height: 400
  - template:         '/path/to/your/template.erb'

Thanks

@ChrisBAshton ChrisBAshton added this to the 2.8 milestone Nov 5, 2015
This was referenced Nov 5, 2015
@ChrisBAshton ChrisBAshton merged commit d90ca84 into bbc:master Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants