Allow newer nokogiris #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do I need to do anything else to get this merged, @ChrisBAshton? |
|
Hi @johnsyweb - sorry for the slow reply on this. Are you sure this is what you're intending? Merging this PR will install newer versions of Nokogiri up-to-and-NOT-including 1.7.0 (according to http://guides.rubygems.org/patterns/ - "Had we said EDIT: Looking more closely at the linked issue, you're looking at Nokogiri version Happy to merge 👍 |
|
Thank you. We bumped Nokogiri to 1.6.8.rc3 and the number of segmentation faults in our Rails application dropped by about 50%! |
|
And now they're all gone: sparklemotion/nokogiri#1426 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I'd like to use a later version of Nokogiri to test a fix for sparklemotion/nokogiri#1426
Change
Relax nokogiri version