Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

music hangs when playing None #776

Closed
rhubarbdog opened this issue Oct 22, 2022 · 1 comment
Closed

music hangs when playing None #776

rhubarbdog opened this issue Oct 22, 2022 · 1 comment
Labels
bug
Milestone
Version 1.1.1

Comments

@rhubarbdog
Copy link
Contributor

The program

from microbit import *
import music

music.play([None])

hangs the microbit
@microbit-carlos microbit-carlos mentioned this issue Oct 24, 2022
Closed
@microbit-carlos microbit-carlos added this to the Version 1.1.1 milestone Oct 24, 2022
dpgeorge added a commit that referenced this issue Oct 28, 2022
@dpgeorge
microbit: Remove support for None as a tune rest.
b0397e9 
It was broken ever since background music was introduced, in
0189136

Fixes issue #776.

Signed-off-by: Damien George <damien@micropython.org>
dpgeorge added a commit that referenced this issue Oct 28, 2022
@dpgeorge
microbit: Remove support for None as a tune rest.
faea92e 
It was broken ever since background music was introduced, in
0189136

Fixes issue #776.

Signed-off-by: Damien George <damien@micropython.org>
dpgeorge added a commit that referenced this issue Oct 28, 2022
@dpgeorge
microbit: Remove support for None as a tune rest.
1a385d3 
It was broken ever since background music was introduced, in
0189136 (it needs to add ticker_ticks_ms
to the calculated async_wait_ticks, and also increment async_notes_index).

Fixes issue #776.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge
Copy link
Member

Fixed by 1a385d3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Version 1.1.1
Development

No branches or pull requests
3 participants
@dpgeorge @microbit-carlos @rhubarbdog