Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified and expanded PR for piezo buzzer issues. #520

Closed
wants to merge 5 commits into from
Closed

Unified and expanded PR for piezo buzzer issues. #520

wants to merge 5 commits into from

Conversation

ScottDWebster
Copy link
Contributor

Here's a single pull request encompassing my previous requests plus additional text.

Expanded the introduction to piezo buzzers to explain that there are two types with slightly different uses.  It is important that the student/user be using an active buzzer for the example code to work.
Added text stating that a passive piezo buzzer could be used as an alternative to a speaker and updated the warning to say that active piezo buzzers shouldn't be used.
Attempted to further clarify that either a speaker or passive buzzer could be used in the exercise.
Removed unintentionally added whitespace.
I don't have extensive knowledge of or experience with passive piezo buzzers, but the one I have on hand (from an Arduino kit) has one side marked with a plus sign though it works the same when hooked up either way,
@dpgeorge
Copy link
Member

dpgeorge commented Jun 5, 2018

Thanks for the contribution. Actually, this was already "fixed" once, see #237 and #285. But if it's still causing confusion then maybe it does need further clarification.

@dpgeorge
Copy link
Member

dpgeorge commented Sep 6, 2021

Squashed and merged in e8df727

@dpgeorge dpgeorge closed this Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants