New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix the table in pin.rst to match the diagram #659

Merged

dpgeorge merged 1 commit into bbcmicrobit:master from mattheww:2019-04_pin.rst

Apr 9, 2019

Contributor

mattheww commented Apr 8, 2019

The pin table in pins.rst disagrees with the diagram:

it says three of the edge connector pins are for the LED rows, rather than columns 7, 8, and 9;
it has the three SPI pins in the opposite order

I think the diagram is right and the table is wrong:

pinmap.csv says the three LED pins are internal GPIOs 10,11,12 which are definitely columns;
spi.rst has sclk=pin13, mosi=pin15, miso=pin14 .


          docs: fix the table in pin.rst to match the diagram

a92ca9b

dpgeorge merged commit a92ca9b into bbcmicrobit:master

Member

dpgeorge commented Apr 9, 2019

Thanks for the contribution, you are correct!

The fix here also matches the code, source/microbit/microbitspi.cpp, and the display pin mappings in source/microbit/microbitdisplay.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet