Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Async::HTTP::WebMockClientWrapper mock interface #1061

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

postmodern
Copy link
Contributor

@postmodern
Copy link
Contributor Author

JRuby failure looks unrelated.

@bblimke
Copy link
Owner

bblimke commented Jul 15, 2024

@postmodern Thank you for the PR and for making these changes. I noticed that these modifications to Async::HTTP::Client were made 4 years ago. I'm curious why no one has raised concerns about this issue until now.

@bblimke bblimke merged commit 871f32e into bblimke:master Jul 15, 2024
7 of 8 checks passed
@postmodern
Copy link
Contributor Author

@bblimke you're welcome. I'm guessing because no one probably tests the the Async::HTTP::Client#endpoint value, just that it makes the appropriate requests. In my code I wanted to make sure I was connecting to the correct HTTP endpoint in #initialize, so I needed to access subject.client.endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants