-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace LOG4J12 with LOG4J2 #43
Comments
Please reconsider adding a dependency on a concrete slf4j implementation. In my opinion, libraries better depend only on the api alone (and all the ones I know do so, I can provide examples if you want). The current approach only works without configuration when the user:
In all other scenarios it introduces version or binding conflicts and users have to hunt down the reason. If there is no binding to an implementation, slf4j will print a warning. If users want logging output, they should know what concrete logging system they are using and how to configure it. |
@zimmi I was thinking of providing documentation to exclude the log4j2 implementation from the maven dependencies so you can switch to another. The API that is used in the code already is that of SLF4J. However, if using the basic SLF4J implementation logging requires no further configuration from the user if they want to switch implementation, that would be preferable. I only included some implementation so that the demo and test classes produce output. |
What do you think about instead providing documentation to add log4j2 as the recommended modern logging implementation? Adding a link to the slf4j manual for the demo code for users that want logging output might be enough, maybe. |
I added it as an optional dependency using the maven |
I also moved the log4j config file to the test resources folder now so that won't be packaged either (see #45). |
I agree with that decision. :) |
After moving to log4j12 in #14, let's modernize further and move to log4j2 as default logging implementation.
The text was updated successfully, but these errors were encountered: